-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename member variables and add new ones #45
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 84.03% 84.08% +0.04%
==========================================
Files 42 42
Lines 2775 2783 +8
==========================================
+ Hits 2332 2340 +8
Misses 443 443 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments: make sure that the functions you added/edited that don't modify the class have the const
suffix. Thank you!
@gvegayon I just added the |
The PR introduces renames to several member variables and their associated getters to better reflect their functionality. In particular, this involves pre-pending the word "all" to variables that include data for multiple samples.
It also adds new member variables
m_current_proposed_stats
andm_current_accepted_stats
with getters and updates them accordingly in therun()
function.