feat: store memory footprints to grafana

Unleash · Dec 19, 2024 · 8d77f69 · 8d77f69
1 parent dc9a58b
commit 8d77f69
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/src/lib/features/client-feature-toggles/delta/client-feature-toggle-delta.ts b/src/lib/features/client-feature-toggles/delta/client-feature-toggle-delta.ts
@@ -5,6 +5,7 @@ import type {
     IFeatureToggleQuery,
     IFlagResolver,
     ISegmentReadModel,
+    IUnleashConfig,
 } from '../../../types';
 import type ConfigurationRevisionService from '../../feature-toggle/configuration-revision-service';
 import { UPDATE_REVISION } from '../../feature-toggle/configuration-revision-service';
@@ -15,6 +16,7 @@ import type {
 } from './client-feature-toggle-delta-read-model-type';
 import { CLIENT_DELTA_MEMORY } from '../../../metric-events';
 import type EventEmitter from 'events';
+import type { Logger } from '../../../logger';
 
 type DeletedFeature = {
     name: string;
@@ -115,21 +117,24 @@ export class ClientFeatureToggleDelta {
 
     private eventBus: EventEmitter;
 
+    private readonly logger: Logger;
+
     constructor(
         clientFeatureToggleDeltaReadModel: IClientFeatureToggleDeltaReadModel,
         segmentReadModel: ISegmentReadModel,
         eventStore: IEventStore,
         configurationRevisionService: ConfigurationRevisionService,
         flagResolver: IFlagResolver,
-        eventBus: EventEmitter,
+        config: IUnleashConfig,
     ) {
         this.eventStore = eventStore;
         this.configurationRevisionService = configurationRevisionService;
         this.clientFeatureToggleDeltaReadModel =
             clientFeatureToggleDeltaReadModel;
         this.flagResolver = flagResolver;
         this.segmentReadModel = segmentReadModel;
-        this.eventBus = eventBus;
+        this.eventBus = config.eventBus;
+        this.logger = config.getLogger('delta/client-feature-toggle-delta.js');
         this.onUpdateRevisionEvent = this.onUpdateRevisionEvent.bind(this);
         this.delta = {};
 
@@ -303,10 +308,14 @@ export class ClientFeatureToggleDelta {
     }
 
     storeFootprint() {
-        const featuresMemory = this.getCacheSizeInBytes(this.delta);
-        const segmentsMemory = this.getCacheSizeInBytes(this.segments);
-        const memory = featuresMemory + segmentsMemory;
-        this.eventBus.emit(CLIENT_DELTA_MEMORY, { memory });
+        try {
+            const featuresMemory = this.getCacheSizeInBytes(this.delta);
+            const segmentsMemory = this.getCacheSizeInBytes(this.segments);
+            const memory = featuresMemory + segmentsMemory;
+            this.eventBus.emit(CLIENT_DELTA_MEMORY, { memory });
+        } catch (e) {
+            this.logger.error('Client delta footprint error', e);
+        }
     }
 
     getCacheSizeInBytes(value: any): number {

diff --git a/src/lib/features/client-feature-toggles/delta/createClientFeatureToggleDelta.ts b/src/lib/features/client-feature-toggles/delta/createClientFeatureToggleDelta.ts
@@ -28,7 +28,7 @@ export const createClientFeatureToggleDelta = (
         eventStore,
         configurationRevisionService,
         flagResolver,
-        eventBus,
+        config,
     );
 
     return clientFeatureToggleDelta;