fix: support both snake_case and camelCase versions of impression data #803
Triggered via pull request
September 25, 2024 16:28
gastonfournier
Status
Failure
Total duration
1m 16s
Artifacts
–
tests.yaml
on: pull_request
Matrix: Test code style
Matrix: Static analysis
Matrix: Tests
Matrix: Tests (transpiled versions)
Annotations
3 errors
|
Static analysis (8.3):
src/DTO/DefaultProxyFeature.php#L49
Offset 'impression_data' does not exist on array{name: string, enabled: bool, variant: array{name: string, enabled: bool, payload?: array{type: string, value: string}}, impression_data?: bool, impressionData?: bool}.
|
|
Static analysis (8.3):
src/Repository/DefaultUnleashProxyRepository.php#L178
Method Unleash\Client\Repository\DefaultUnleashProxyRepository::validateResponse() should return array{name: string, enabled: bool, variant: array{name: string, enabled: bool, payload?: array{type: string, value: string}}, impression_data?: bool, impressionData?: bool}|null but returns array<string, mixed>.
|
|
Static analysis (8.3)
Process completed with exit code 1.
|