Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pins to heatmap result statistics, make opacity/saturation configurable #727

Merged

Conversation

jxjj
Copy link
Contributor

@jxjj jxjj commented Sep 15, 2023

This adds pins to heatmap results display, and allows presenters to adjust the opacity and saturation of an image to make the heatmap/pins more visible.

ScreenShot 2023-09-15 at 11 18 29@2x ScreenShot 2023-09-15 at 11 19 02@2x

Also:

  • adds some typing to Question and Response types
  • fixes an issue where no alt would show for image heatmap. There's no image_alt property on heatmap question info, just image_name. Using image_name as a fallback for now, but see Allow users to set alt attribute on Heatmap question images #726
  • fixes an issue where resizing the window wouldn't update the heatmap/pin location
  • fixes a type issue with hideWordcloud. (Technically, I guess there could be problems when evaluating responses.hideWordcloud since responses could be an array?)

Questions:

  • Since this is now a pin/heatmap style question, should we update the name? Other ChimeIn like apps call it something like "Drop Pin" or "Pin on Image"... but these don't have heatmaps afaik.
  • Should the response input be updated to use a pin icon rather than a red circle for visual consistency?
  • Do we need to do any fuzzing of coordinates so pins don't overlap? (My thinking is no, since heatmap would reveal multiple clicks on the same spot).
  • Better layout for range or checkboxes? It looked strange above the image (there are a lot of control boxes on the page). Should we hide them behind a button?
  • Are there better defaults when showing results? I wonder if 50% saturation and 50% opacity is better than 100%/100%?

Test screenshot still needs to be updated

jxjj added 11 commits September 14, 2023 11:14
somewhat different from what's actually used
This question type may not have an alt attribute.
For FreeResponse question types, the default `question_responses` property is an array. Only when hideWordcloud is checked does it become an object.
Is this better? I dunno.
@jxjj jxjj requested a review from cmcfadden September 15, 2023 16:52
@jxjj jxjj self-assigned this Sep 15, 2023
@jxjj
Copy link
Contributor Author

jxjj commented Sep 15, 2023

btw, on dev for testing

@jxjj jxjj linked an issue Sep 15, 2023 that may be closed by this pull request
Copy link
Member

@cmcfadden cmcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change itself looks good - when I'm back in the office, let's do some brainstorming on name (or name change) and how to default some of the controls.

@jxjj jxjj merged commit c08ef76 into develop Sep 18, 2023
@jxjj jxjj deleted the feature/703-Add-drop-a-pin-style-clickable-image-question branch September 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add drop a pin style clickable image question
2 participants