-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pins to heatmap result statistics, make opacity/saturation configurable #727
Merged
jxjj
merged 12 commits into
develop
from
feature/703-Add-drop-a-pin-style-clickable-image-question
Sep 18, 2023
Merged
Add pins to heatmap result statistics, make opacity/saturation configurable #727
jxjj
merged 12 commits into
develop
from
feature/703-Add-drop-a-pin-style-clickable-image-question
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somewhat different from what's actually used
This question type may not have an alt attribute.
For FreeResponse question types, the default `question_responses` property is an array. Only when hideWordcloud is checked does it become an object.
btw, on dev for testing |
cmcfadden
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change itself looks good - when I'm back in the office, let's do some brainstorming on name (or name change) and how to default some of the controls.
jxjj
deleted the
feature/703-Add-drop-a-pin-style-clickable-image-question
branch
September 18, 2023 17:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pins to heatmap results display, and allows presenters to adjust the opacity and saturation of an image to make the heatmap/pins more visible.
Also:
image_alt
property on heatmap question info, justimage_name
. Usingimage_name
as a fallback for now, but see Allow users to set alt attribute on Heatmap question images #726responses.hideWordcloud
sinceresponses
could be an array?)Questions:
Test screenshot still needs to be updated