Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Added the ability to send messages to Telegram topics… #928

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

medaved
Copy link

@medaved medaved commented Dec 7, 2024

Summary

  • Added the ability to send messages to Telegram topics in groups.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@TwiN
Copy link
Owner

TwiN commented Dec 8, 2024

Hey, just so you know, I'm currently working on #929, which may also implement what this PR is implementing.

@medaved
Copy link
Author

medaved commented Dec 9, 2024

@TwiN how can i help with this?

@TwiN
Copy link
Owner

TwiN commented Dec 16, 2024

Hey, sorry about this, I'm going to close this because I've been working on adding support for provider overrides at the alert level, and this impacts how overrides in general work. The good news is that you'll be able to override the topic parameter with this change, making this PR no longer necessary.

I am, however, very thankful for your contribution!

@TwiN TwiN closed this Dec 16, 2024
@TwiN TwiN added the duplicate This issue or pull request already exists label Dec 16, 2024
@0n1cOn3
Copy link

0n1cOn3 commented Jan 6, 2025

Hey @TwiN

I don't see any connection here. Telegram Topics have nothing to do with the endpoints per se. But rather that support for topics is introduced here. It would make notifications a lot easier to handle and would no longer clutter up the main chat. Please take another look at this PR :)

@TwiN TwiN reopened this Jan 7, 2025
@TwiN
Copy link
Owner

TwiN commented Jan 7, 2025

@0n1cOn3 oh crap, you're completely right. I went through the files changes way too quickly, saw green and overrides & assumed it was the change 🤦‍♂️

@medaved
Copy link
Author

medaved commented Jan 7, 2025

@TwiN PR refreshed, because old commit had conflicts

@TwiN TwiN added area/alerting Related to alerting feature New feature or request and removed duplicate This issue or pull request already exists labels Jan 16, 2025
@TwiN
Copy link
Owner

TwiN commented Jan 16, 2025

@medaved Some tests are failing

# github.com/TwiN/gatus/v5/alerting/provider/telegram [github.com/TwiN/gatus/v5/alerting/provider/telegram.test]
Error: alerting/provider/telegram/telegram_test.go:159:32: unknown field ID in struct literal of type AlertProvider
Error: alerting/provider/telegram/telegram_test.go:159:43: unknown field TopicId in struct literal of type AlertProvider

@medaved
Copy link
Author

medaved commented Jan 23, 2025

@TwiN broken tests were fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants