-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerting): Added the ability to send messages to Telegram topics… #928
base: master
Are you sure you want to change the base?
Conversation
Hey, just so you know, I'm currently working on #929, which may also implement what this PR is implementing. |
@TwiN how can i help with this? |
Hey, sorry about this, I'm going to close this because I've been working on adding support for provider overrides at the alert level, and this impacts how overrides in general work. The good news is that you'll be able to override the topic parameter with this change, making this PR no longer necessary. I am, however, very thankful for your contribution! |
Hey @TwiN I don't see any connection here. Telegram Topics have nothing to do with the endpoints per se. But rather that support for topics is introduced here. It would make notifications a lot easier to handle and would no longer clutter up the main chat. Please take another look at this PR :) |
@0n1cOn3 oh crap, you're completely right. I went through the files changes way too quickly, saw green and overrides & assumed it was the change 🤦♂️ |
c716f8f
to
1729069
Compare
1729069
to
67e46f1
Compare
@TwiN PR refreshed, because old commit had conflicts |
@medaved Some tests are failing
|
… in groups. fix tests
@TwiN broken tests were fixed |
Summary
Checklist
README.md
, if applicable.