Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline.jl: refactor to make API uniform #80

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

suvayu
Copy link
Member

@suvayu suvayu commented Oct 22, 2024

Everything is now handled with function dispatch. Also add a nicer
way to join with Julia objects: as_table that support do-blocks.

Related issues

Closes #34

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

Everything is now handled with function dispatch.  Also add a nicer
way to join with Julia objects: `as_table` that support `do`-blocks.
@suvayu suvayu requested a review from abelsiqueira October 22, 2024 00:40
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (cb9cbbc) to head (5fc3ba5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/pipeline.jl 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   66.41%   66.91%   +0.49%     
==========================================
  Files           6        6              
  Lines         268      266       -2     
==========================================
  Hits          178      178              
+ Misses         90       88       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suvayu
Copy link
Member Author

suvayu commented Oct 22, 2024

Looks like there are no tests for tbl_select

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made some suggestions.

src/pipeline.jl Outdated Show resolved Hide resolved
src/pipeline.jl Show resolved Hide resolved
Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@suvayu suvayu merged commit 6bc433b into TulipaEnergy:main Oct 22, 2024
6 checks passed
@suvayu suvayu deleted the 34_set_tbl_col branch October 22, 2024 13:02
@clizbe
Copy link
Member

clizbe commented Oct 24, 2024

Welcome back, @suvayu! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to refactor set_tbl_col_impl into a "wrapper" to convert Julia data to DDB
3 participants