-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline.jl: refactor to make API uniform #80
Conversation
Everything is now handled with function dispatch. Also add a nicer way to join with Julia objects: `as_table` that support `do`-blocks.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 66.41% 66.91% +0.49%
==========================================
Files 6 6
Lines 268 266 -2
==========================================
Hits 178 178
+ Misses 90 88 -2 ☔ View full report in Codecov by Sentry. |
Looks like there are no tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've made some suggestions.
64cfc08
to
23ce417
Compare
23ce417
to
5fc3ba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update
Welcome back, @suvayu! :D |
Everything is now handled with function dispatch. Also add a nicer
way to join with Julia objects:
as_table
that supportdo
-blocks.Related issues
Closes #34
Checklist