Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap option handling in a function #48

Closed
wants to merge 1 commit into from

Conversation

suvayu
Copy link
Member

@suvayu suvayu commented May 11, 2024

I considered using Val but it doesn't really work since it's also
required to invoke the fuction with Val{value}, instead of just
passing value (unless I misunderstood how this works).

So I essentially factored out the logic to a regular function, and
wrote tests to cover all behaviours.

Thoughts?

@suvayu suvayu requested a review from abelsiqueira May 11, 2024 13:58
@suvayu suvayu linked an issue May 11, 2024 that may be closed by this pull request
@suvayu
Copy link
Member Author

suvayu commented May 11, 2024

Looks like I misunderstood how to use Val :-p

@suvayu suvayu closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor use of name, tmp, show triplet
1 participant