Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove graph from src/constraints/storage.jl #981

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Remove graph from src/constraints/storage.jl #981

merged 1 commit into from
Dec 19, 2024

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Dec 19, 2024

Blocked by #978, #979, #980

  • Remove graph from src/constraints/storage.jl

Part of #942
Closes #955

@abelsiqueira abelsiqueira changed the title 942 storage Remove graph from src/constraints/storage.jl Dec 19, 2024
@abelsiqueira abelsiqueira added the benchmark PR only - Run benchmark on PR label Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Benchmark Results

1694227... 3a90396... 1694227.../3a90396a4dccd9...
energy_problem/create_model 43.6 ± 3.1 s 45 ± 2.7 s 0.969
energy_problem/input_and_constructor 17.5 ± 0.41 s 17 ± 0.48 s 1.03
time_to_load 4.23 ± 0.01 s 4.3 ± 0.028 s 0.982
1694227... 3a90396... 1694227.../3a90396a4dccd9...
energy_problem/create_model 0.569 G allocs: 22.1 GB 0.545 G allocs: 22 GB 1
energy_problem/input_and_constructor 0.0532 G allocs: 1.98 GB 0.0532 G allocs: 1.98 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (1694227) to head (3a90396).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
+ Coverage   95.31%   95.34%   +0.03%     
==========================================
  Files          29       29              
  Lines        1110     1118       +8     
==========================================
+ Hits         1058     1066       +8     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira marked this pull request as ready for review December 19, 2024 13:51
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during online meeting

@datejada datejada merged commit f421d02 into main Dec 19, 2024
6 of 7 checks passed
@datejada datejada deleted the 942-storage branch December 19, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't get data from graph object in src/constraints/storage.jl
2 participants