Apply BestieTemplate v0.12.0 #848
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
===========================================
- Coverage 100.00% 99.90% -0.10%
===========================================
Files 20 20
Lines 1021 1017 -4
===========================================
- Hits 1021 1016 -5
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
abelsiqueira
force-pushed
the
apply-bestie
branch
from
9389e1f to
c8ad97d
Compare
| uses: ./.github/workflows/ReusableTest.yml | ||
| with: | ||
| os: ubuntu-latest | ||
| version: "1" |
There was a problem hiding this comment.
| version: "1" | |
| version: "lts" |
There was a problem hiding this comment.
This we keep as "1", to test only on the latest release (1.11)
There was a problem hiding this comment.
So, should we test in both? "1" and "lts" since this is how we are doing the test on PRs currently
There was a problem hiding this comment.
We can do that, yes. I'll make the suggestion
| version: "1" | |
| version: | |
| - "lts" | |
| - "1" |
.github/workflows/TestOnPR.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| version: | ||
| - "1.6" |
There was a problem hiding this comment.
| - "1.6" | |
| - "lts" |
.github/workflows/TestOnPR.yml
Outdated
There was a problem hiding this comment.
Do we need this file? I think Bestie uses now TestOnPRs.yml instead (just checking)
There was a problem hiding this comment.
We must have forgotten to delete
abelsiqueira
force-pushed
the
apply-bestie
branch
from
c8ad97d to
5f92620
Compare
Add codecov configuration file. Set 95% coverage as target for the project. Set the yellow range to 90%-95%. Closes TulipaEnergy#849
abelsiqueira
force-pushed
the
apply-bestie
branch
from
068691e to
f63598c
Compare
Pull request details
Describe the changes made in this pull request
Explicitly make Julia 1.6 the minimum supported version
Apply BestieTemplate v0.12.0
List of related issues or pull requests
Closes #676
Collaboration confirmation
As a contributor I confirm