Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an expression that covers both simple and compact methods #800

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

gnawin
Copy link
Member

@gnawin gnawin commented Sep 17, 2024

Pull request details

Describe the changes made in this pull request

  • Add new expression that is either accumulate_capacity_simple_method or accumulate_capacity_compact_method depending on the asset. For the latter, sum over all v, following the method used for the capacity constraint.
  • Sum all vintage years to get the total initial units for simple method
  • Change names from accumulated_capacity* to accumulated_units*

List of related issues or pull requests

Closes #798

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (21650c1) to head (13094ac).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #800   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          961       964    +3     
=========================================
+ Hits           961       964    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait, if @abelsiqueira has comments on the code

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datejada datejada merged commit 0fe4d8f into TulipaEnergy:main Sep 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change accumulated capacity expression to account for both investment methods
3 participants