Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid missing value investment method #795

Merged

Conversation

datejada
Copy link
Member

@datejada datejada commented Sep 12, 2024

Pull request details

Describe the changes made in this pull request

Instead of missing, we add the option none to account for the cases where we don't want any investment variable for that asset at all.

Case study files are updated accordingly.

List of related issues or pull requests

Closes #794

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • [NA] The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@datejada datejada requested a review from gnawin September 12, 2024 13:43
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b2a73e6) to head (3f7c8b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #795   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          904       904           
=========================================
  Hits           904       904           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada datejada marked this pull request as ready for review September 12, 2024 13:57
Copy link
Member

@gnawin gnawin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@gnawin gnawin merged commit 1868e94 into TulipaEnergy:main Sep 12, 2024
7 checks passed
@datejada datejada deleted the 794-avoid-missing-value-investment-method branch September 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid having missing value in the investment_method
2 participants