Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add investment method to the graph structure #788

Merged

Conversation

datejada
Copy link
Member

@datejada datejada commented Sep 11, 2024

Pull request details

Describe the changes made in this pull request

Add the investment method to the graph structure to differentiate the investment method to use it in the model. Currently, the parameter is read, but it is not available in the graph.

List of related issues or pull requests

Closes #787

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a40c96b) to head (f342e73).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #788   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          904       904           
=========================================
  Hits           904       904           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada datejada marked this pull request as ready for review September 11, 2024 07:53
@datejada
Copy link
Member Author

@abelsiqueira For the changes @gnawin and I are working on, we both need this change. That is why I have created a separate issue so we can both pull the latest changes from the main branch.

And...to follow the atomic commit principles, master! 🧙

@abelsiqueira abelsiqueira merged commit b2a73e6 into TulipaEnergy:main Sep 11, 2024
7 checks passed
@datejada datejada deleted the 787-add-investment-method-to-graph branch September 11, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add investment_method data to the graph structure
2 participants