Include duration in the ramping constraints #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 891 900 +9
=========================================
+ Hits 891 900 +9 ☔ View full report in Codecov by Sentry. |
abelsiqueira
reviewed
Sep 6, 2024
abelsiqueira
reviewed
Sep 6, 2024
abelsiqueira
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Summary of the comments:
- Instead of storing a whole vector and computing the minimum, start with a large value and update the minimum every time. It's faster than
push!and better for memory. An alternative would be to store a whole vector with predetermined size, but I am not sure that would be faster, and it would definitely use more memory.
datejada
force-pushed
the
772-include-durations-ramping-constraints
branch
from
8fc7a0a to
868aa1d
Compare
@abelsiqueira, thanks for the suggestion. The PR is updated and rebased to the latest version in main 😄 Please let me know if you have more comments. |
abelsiqueira
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request details
Describe the changes made in this pull request
Include the duration in the ramping constraints in the RHS of the equations to account for that the ramp parameters are given as rates.
List of related issues or pull requests
Closes #772
Collaboration confirmation
As a contributor I confirm