Split static graph data and add is_milestone to years' data

[abelsiqueira]

Pull request details

Describe the changes made in this pull request

• Move the "static" graph information to separate files (i.e., data that does not depend on year)
• Create a column is_milestone in year-data.csv
• Change all test files with the changes above
• Add Year struct and schema

List of related issues or pull requests

Closes #766

Collaboration confirmation

As a contributor I confirm

• I read and followed the instructions in README.dev.md
• The documentation is up to date with the changes introduced in this Pull Request (or NA)
• Tests are passing
• Lint is passing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c1c5103) to head (40ab843).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #768   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          887       888    +1     
=========================================
+ Hits           887       888    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gnawin]

Hi @abelsiqueira thanks for the PR. It looks good, I just left a minor comment. And a question for the flow investment.

[gnawin]

Maybe we need to add investment_method to flows (for transport investment), otherwise what formulation do we want to use for flows? @datejada @g-moralesespana

[gnawin]

Given the reply from German on Teams, indeed we will only use simple method for transport investment. We can either leave it empty, meaning we will use simple by default. Or we can add investment_method here and specify simple here. @abelsiqueira What do you think?

[abelsiqueira]

Those are different things. Adding a column means that we can change the investment method, even if you add a column that is empty by default. If the column has no meaning right now, then I would not add it.

[gnawin]

Thank you @abelsiqueira. LTGM!