Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inline backticks to avoid italics from underscores #439

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

clizbe
Copy link
Member

@clizbe clizbe commented Feb 5, 2024

Pull request details

Describe the changes made in this pull request

Didn't build the docs locally, so hope it worked.

List of related issues or pull requests

Closes #434

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6b74e2) 100.00% compared to head (27ef993) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          528       528           
=========================================
  Hits           528       528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Have you been able to create the documentation locally and check that it works?

@clizbe
Copy link
Member Author

clizbe commented Feb 6, 2024

No I put in the PR that I didn't cuz I was lazy. But I can do it today and get back to you. :P

@clizbe
Copy link
Member Author

clizbe commented Feb 6, 2024

Yup built it locally and looks good! :)

@clizbe clizbe requested a review from datejada February 6, 2024 14:48
@datejada datejada merged commit 6554766 into TulipaEnergy:main Feb 6, 2024
7 checks passed
@clizbe clizbe deleted the 434_docs_bug branch May 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Parsing underscores in documentation
2 participants