Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running codecov only on ubuntu-latest for Julia 1 #423

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Jan 23, 2024

Pull request details

Describe the changes made in this pull request

Tentative solution to show the badge on codecov.
The src/TulipaEnergyModel.jl change is insignificant just to trigger the TestOnPR.yml workflow.

List of related issues or pull requests

Maybe fix #422, have to check after merging.

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d680ca) 100.00% compared to head (9918c44) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #423   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          414       414           
=========================================
  Hits           414       414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira marked this pull request as ready for review January 23, 2024 10:36
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datejada datejada merged commit a24517d into TulipaEnergy:main Jan 23, 2024
7 checks passed
@abelsiqueira abelsiqueira deleted the 422-codecov branch January 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - The codecov badge in the README.md status is unknown
2 participants