Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename index to id to prevent using sql keyword #1061

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

abelsiqueira
Copy link
Member

Some cleaning in preparation to some SQL files. This changes all index to id, because index is a reserved keyword in some parts of SQL.

Related issues

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.86%. Comparing base (feb0cb7) to head (7e1400d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/expressions/intersection.jl 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files          29       29           
  Lines         985      985           
=======================================
  Hits          964      964           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved during teams meeting

@abelsiqueira abelsiqueira merged commit 2bb3e94 into TulipaEnergy:main Mar 3, 2025
5 checks passed
@abelsiqueira abelsiqueira deleted the rename-index-to-id branch March 3, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants