Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change multi-year fixed and investment costs to help differentiate and fix objective fixed costs #1048

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Feb 24, 2025

The objective fixed cost were being selected from milestone_years only.

Closes #1046

…d fix objective fixed costs

The objective fixed cost were being selected from milestone_years only.

Closes #1046
@abelsiqueira abelsiqueira force-pushed the 1046-fix-multi-year-and-objective branch from cedd7d6 to d578618 Compare February 24, 2025 14:12
@abelsiqueira abelsiqueira changed the title 1046 fix multi year and objective Change multi-year fixed and investment costs to help differentiate and fix objective fixed costs Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (a7c7b36) to head (d578618).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files          29       29           
  Lines         982      982           
=======================================
  Hits          961      961           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira marked this pull request as ready for review February 24, 2025 14:38
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed in person at the Tulipa day

@datejada datejada merged commit 68c3bcc into main Feb 24, 2025
7 checks passed
@datejada datejada deleted the 1046-fix-multi-year-and-objective branch February 24, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix multi-year data and fix objective function
2 participants