Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .all-contributorsrc and run generate changing some links #1005

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

abelsiqueira
Copy link
Member

I've changed the links of Juha and Matthijs to be the GitHub link to help the link checker.
I changed it on the .all-contributorsrc file and ran the all contributors generator locally. It ended changing more than I was expecting, but apparently these links are correct and the old ones were not.
Next time we update the all-contributors file, we see how much it changes and decide how to proceed.

Also, it looks like the ieeexplore.ieee.org site is down, but that is not necessarily something that happens often.

Related issues

There is no related issue.

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@datejada datejada marked this pull request as ready for review January 28, 2025 16:17
@datejada datejada self-requested a review January 28, 2025 16:17
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, hopefully the links won't give more problems in the future 😊

@datejada datejada merged commit 8ee7150 into TulipaEnergy:main Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants