Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a progress bar to weight fitting #25

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

greg-neustroev
Copy link
Collaborator

Pull request details

Describe the changes made in this pull request

Added an optional progress bar for the weight fitting method. This is useful when there are many periods to find weights for, as the method can take a while to run.

List of related issues or pull requests

Closes #22

@greg-neustroev greg-neustroev requested a review from clizbe December 6, 2023 15:36
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d330b15) 100.00% compared to head (c96b6b5) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          214       218    +4     
=========================================
+ Hits           214       218    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@datejada datejada merged commit b90adbf into TulipaEnergy:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add progress bars
2 participants