Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement methods for finding representative period weights #10

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

greg-neustroev
Copy link
Collaborator

Pull request details

Describe the changes made in this pull request

Implemented methods for finding the following types of representative period representations:

  • Convex sums: the weights are non-negative and add into one.
  • Conical sums: the weights are non-negative.
  • Conical sums with a bounded total weight: the weights are non-negative and add at most into one.

List of related issues or pull requests

Closes #4

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c5e7d9) 100.00% compared to head (3c1f6f1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines          129       212   +83     
=========================================
+ Hits           129       212   +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@datejada datejada merged commit 6a21c7f into main Dec 5, 2023
13 checks passed
@datejada datejada deleted the 4-weighting branch December 5, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement weighting
2 participants