-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!(server/pipeline): raise UndefinedVariableError when variables are missing during rendering [TCTC-10013] #2361
refactor!(server/pipeline): raise UndefinedVariableError when variables are missing during rendering [TCTC-10013] #2361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you please also add an entry to the changelog ?
Also, the PR title isn't very explicit to me, how about something like "refactor!(server/pipeline): raise UndefinedVariableError
when variables are missing during rendering"
Co-authored-by: Luka Peschke <[email protected]>
Thanks for the review ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
Co-authored-by: Luka Peschke <[email protected]>
When there is a pipeline with a variable and a value is not provided, we get this error:
This PR uses an already there param in
toucan-connectors::nosql_apply_parameters_to_query
to getUndefinedVariableError
instead.This PR adds
nosql_apply_parameters_to_query
inweaverbird.utils.toucan_connectors
to use this param everywhere, and a test to match.