feat(deps): upgrade pyo3 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luka Peschke <[email protected]>
Signed-off-by: Luka Peschke <[email protected]>
lukapeschke
added
enhancement
PrettyWood
reviewed
Jan 19, 2025
| @@ -42,11 +43,32 @@ impl FromPyObject<'_> for IdxOrName { | |||
| } | |||
| } | |||
|
|
|||
| impl ToPyObject for IdxOrName { | |||
There was a problem hiding this comment.
Can't you do
impl<'py, T> IntoPyObject<'py> for T where T: AsRef<IdxOrName>to avoid this duplication?
There was a problem hiding this comment.
This is unfortunately not possible,as IdxOrName is not generic over T, which causes T to be considered a foreign type 😕
impl<'py, T: AsRef<IdxOrName>> IntoPyObject<'py> for T {
^ type parameter `T` must be used as the type parameter for some local type
note: implementing a foreign trait is only possible if at least one of the types for which it is implemented is local
note: only traits defined in the current crate can be implemented for a type parameter
There was a problem hiding this comment.
Ah fk yes. The orphan rule striking again. LGTM then
PrettyWood
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.