Links for embedding models elsewhere #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidahoderinwale
force-pushed
the
embedwidget
branch
from
aee22bb to
5357af8
Compare
epatters
added
enhancement
epatters
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks for starting this PR! Things to do:
- Lots of unrelated stuff has been accidentally committed
- Rather than having a separate embed button and dialog, a button to copy the link should be adding to the sharing/permissions dialogs where appropriate. See, for instance, how Google Docs does it, or ask me if you have questions.
hamidahoderinwale
force-pushed
the
embedwidget
branch
from
39d056a to
57b4bf2
Compare
hamidahoderinwale
force-pushed
the
embedwidget
branch
from
28683fe to
74a821a
Compare
hamidahoderinwale
force-pushed
the
embedwidget
branch
from
74a821a to
27e3d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When button is selected (CodeXml icon) users can copy iframe code with settings preset.
In the future, maybe users could change style settings and select specific parts of their model (via notebook cells).