Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP-1535: Validar link de img en carousel y bugsfixing #1886

Merged
merged 8 commits into from
Jun 25, 2024
Merged

TP-1535: Validar link de img en carousel y bugsfixing #1886

merged 8 commits into from
Jun 25, 2024

Conversation

emanuelheredia
Copy link
Contributor

TP-1535

Story

  • Se incorpora validación de estado link de imágen para mostrar card estilada en caso de link caído.
  • Se mejora renderizado de carousel ante la asincronía de las validaciones de las imágenes
  • Se incorpora squeletons
  • Se corrige bug de primera imágen a mostrar en fullscreen al presionar sobre la misma.
  • Se actualizan test

@emanuelheredia emanuelheredia self-assigned this Jun 25, 2024
@bsabatino bsabatino merged commit 026f937 into TokkoLabs:development Jun 25, 2024
1 check passed
@emanuelheredia emanuelheredia deleted the carousel_indicator_fixing branch June 26, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguescribano87 aguescribano87 aguescribano87 approved these changes

Assignees

@emanuelheredia emanuelheredia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emanuelheredia @aguescribano87 @bsabatino