Merge pull request #1933 from roberdm49/TP-1686-avoid-dropdown-blink

TP-1686: Ref moved to the parent element
TokkoLabs · Aug 19, 2024 · b60cc57 · b60cc57
2 parents 794a9f8 + bcfa7cd
commit b60cc57
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/packages/dropdown/src/index.js b/packages/dropdown/src/index.js
@@ -15,11 +15,11 @@ export const Dropdown = ({ children, ...props }) => {
 
   useOnClickOutside(ref, () => toggle(false))
 
-  const value = React.useMemo(() => ({ open, toggle, ref }), [open])
+  const value = React.useMemo(() => ({ open, toggle }), [open])
 
   return (
     <DropdownContext.Provider value={value}>
-      <Box {...props} __css={{ position: 'relative', height: '200px' }}>
+      <Box ref={ref} {...props} __css={{ position: 'relative', height: '200px' }}>
         {children}
       </Box>
     </DropdownContext.Provider>
@@ -93,12 +93,11 @@ const DropdownButton = ({ icon, text, variant = 'dropdown', disabled = false, fi
 }
 
 const DropdownList = ({ children, width = '236px', height = '150px', clickClose = false, ...props }) => {
-  const { open, ref, toggle } = useDropdownContext()
+  const { open, toggle } = useDropdownContext()
   return (
     open && (
       <List
         onClick={clickClose ? toggle : () => {}}
-        ref={ref}
         {...props}
         sx={{
           display: 'flex',