Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☑️ Add mypy Checks in tiatoolbox/cli #846

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Conversation

Jiaqi-Lv
Copy link
Contributor

No description provided.

@Jiaqi-Lv Jiaqi-Lv added bug Something isn't working code readability dev tools Changes/Updates in Development tools labels Aug 15, 2024
@Jiaqi-Lv Jiaqi-Lv self-assigned this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (03e7491) to head (d17a02c).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #846   +/-   ##
========================================
  Coverage    99.86%   99.86%           
========================================
  Files           69       69           
  Lines         8656     8656           
  Branches      1653     1653           
========================================
  Hits          8644     8644           
  Misses           4        4           
  Partials         8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaneahmed shaneahmed added this to the Release v1.5.2 milestone Aug 23, 2024
@Jiaqi-Lv Jiaqi-Lv marked this pull request as ready for review September 17, 2024 14:54
@shaneahmed shaneahmed changed the title Fix mypy type errors in tiatoolbox/cli ☑️ Add mypy Checks in tiatoolbox/cli Sep 20, 2024
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiaqi-Lv

@shaneahmed shaneahmed merged commit 6ef915d into develop Sep 20, 2024
27 checks passed
@shaneahmed shaneahmed deleted the mypy-tiatoolbox-cli branch September 20, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code readability dev tools Changes/Updates in Development tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants