Prevent setting non-positive media duration #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `**kwargs` allows us to use any keyword argument in the future. Also, the name `initial` was a remnant from the tkinter era.
Min is necessary as non-positive values may lead to crashes and default is nice when the user (or the developer) just wants to create a timeline and does not care about the specific media duration.
azfoo
approved these changes
Jan 2, 2025
FelipeDefensor
commented
Jan 6, 2025
| @@ -13,17 +13,17 @@ def ask_for_color( | |||
|
|
|||
| def ask_for_int(title: str, prompt: str, **kwargs) -> tuple[bool, int]: | |||
| number, accepted = QInputDialog().getInt(None, title, prompt, **kwargs) | |||
| return accepted, number | |||
| return bool(accepted) & True, number | |||
There was a problem hiding this comment.
Sorry, I didn't get this one. Why do we need this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Min is necessary as non-positive values may lead to crashes and default is nice when the user (or the developer) just wants to create a timeline and does not care about the specific media duration.
I also generalized some ask_for_ functions to make this change easier.