Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint for REST version and capabilities. #5429
Add endpoint for REST version and capabilities. #5429
Changes from 18 commits
5699b42
03bbd4e
3f890c2
d8a54c4
63df0c9
4b60f9d
c004931
f11c152
46896c2
d7eecd4
0b57e9b
1f0816b
708a5b2
65c5b89
5d18c61
cae1f5b
790757f
8c67284
b28995e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have accessors for all private arguments, how about making this a struct as well and simplify things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I guess what I meant is that once we make this a
struct
, we no longer needfriend
or getters for the members. If you think it's important that the member variables are not set outside of the struct or its friends you can revert this to aclass
to preserve those semantics.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha, this should work just fine since
RestClientRemote
returns only a const reference of the struct. I kept theRestClientRemote::rest_tiledb_version()
and similar accessors inRestClientRemote
for convenience, but I removed accessors from the struct itself since they are not needed.