Make Group load_metadata not depend on StorageManager #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #39757: Eliminate load_group_metadata from StorageManager. |
eric-hughes-tiledb
suggested changes
Jan 23, 2024
KiterLuc
force-pushed
the
rbin/ch39757/load_meta_group_sm
branch
from
9493ed0 to
cfaa6f7
Compare
KiterLuc
force-pushed
the
rbin/ch39757/load_meta_group_sm
branch
from
cfaa6f7 to
3cfbd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good starting point for eliminating the dependency of Group on StorageManager
is to move StorageManager load_group_metadata into Group.
TYPE: IMPROVEMENT
DESC: Make Group load_metadata not depend on StorageManager