-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPack to CMakeLists.txt #4645
Conversation
This pull request has been linked to Shortcut Story #38163: Create cmake target for release binary artifacts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's add an example package config (even if it only needs to contain the version for .tar.gz output?)
- Please describe what package targets supported/not-supported in the PR description. The only for sc-38163 is to support the current .tar.gz target (I think you need more config to correctly generate an RPM or NSIS, and we don't need those yet)
- Please add a 1-2 sentence for how to test this in the PR description (just
cpack
in the build dir?)
Here are my questions:
|
Last changes also address:
|
Co-authored-by: Theodore Tsirpanis <[email protected]>
Co-authored-by: Theodore Tsirpanis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's get a +1 from @teo-tsirpanis too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the package
target on my machine and it succeeded and the files in the zip look mostly fine to me. However I noticed that the bin/include/lib
directories in the zip are inside a tiledb-win64-amd64-2.20.0
folder, while in the GitHub Release artifacts they are in the root of the archive. This is a breaking change.
Very good observation, should be fixed now. Thank you @teo-tsirpanis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add CPack to CMakeLists.txt. Currently the binary package was tested an it looks like it works.
All default package exports are enabled for tiledb project so:
![image](https://private-user-images.githubusercontent.com/5787996/297741031-cd187911-67e5-4195-920e-dc7b916157b1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTY3MTksIm5iZiI6MTczOTU5NjQxOSwicGF0aCI6Ii81Nzg3OTk2LzI5Nzc0MTAzMS1jZDE4NzkxMS02N2U1LTQxOTUtOTIwZS1kYzdiOTE2MTU3YjEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDUxMzM5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MmMxY2M3NTY5OWIwYjA1Y2M0ZmM3YWZhNDFkZmYyNDhlNzA5MGM1YWIwYzhlMWU2MDA4ZDBlMDIwMTgyZmE0NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.rdgQSWtKrgG8i48R6A8ofSdyo8rXN9z5xrevk6K6-Bg)
The superbuild's
package
command generates outputs based on the current platform (TGZ for Linux).Usage:
make package
invokescpack
inside of the EP tiledb.cpack
for default behaviour orcpack -G <GENERATOR>
for specific outputmake package
make package_source
Example output from Superbuild's
make package
:TYPE: FEATURE
DESC: Add CPack to CMakeLists.txt