Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource manager template arguments to Class Consolidator and derivates. #4642

Closed
wants to merge 14 commits into from
Closed

Add resource manager template arguments to Class Consolidator and derivates. #4642

wants to merge 14 commits into from

Conversation

eric-hughes-tiledb
Copy link
Contributor

Add resource manager template arguments to Class Consolidator and derivates.

TYPE: NO_HISTORY
DESC: Add resource manager template arguments to Class Consolidator and derivates.

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #39329: Add template arguments to consolidators for resource management.

eric-hughes-tiledb
eric-hughes-tiledb commented Jan 17, 2024
View reviewed changes
Copy link
Contributor Author

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All explicit instantiations need to be commented. See the example in rest_client.cc in the interim PR.

  1. That it's an explicit instantiation.
  2. That it's an interim solution to instantiation.

tiledb/sm/consolidator/array_meta_consolidator.cc Outdated Show resolved Hide resolved
@shaunrd0 shaunrd0 force-pushed the smr/sc-39329/memory-consolidator branch from 76a35e2 to b04a50f Compare January 17, 2024 16:18
@shaunrd0 shaunrd0 force-pushed the smr/sc-39329/memory-consolidator branch from a58ed31 to 3344d1d Compare January 19, 2024 15:59
@shaunrd0
Copy link
Contributor

shaunrd0 commented Jan 19, 2024 •
edited
Loading

Moving to a new PR #4649, thanks for reviewing

@shaunrd0 shaunrd0 closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunrd0 shaunrd0 shaunrd0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-hughes-tiledb @shaunrd0