Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function random_label to utilize PRNG for random string generation #4564

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

bekadavis9
Copy link
Contributor

Add function random_label to utilize PRNG for random string generation.
This function is a migration of random_name from test/support/src/helpers into common/random, which has been modified to use the PRNG. Excess declarations of in-test random_name have been removed from tiledb_unit


TYPE: IMPROVEMENT
DESC: Add function random_label to utilize PRNG for random string generation

Copy link

This pull request has been linked to Shortcut Story #38145: Update function random_name.

Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good. Small things only.

test/src/unit-capi-array.cc Show resolved Hide resolved
tiledb/common/random/helpers.h Outdated Show resolved Hide resolved
tiledb/common/random/helpers.h Outdated Show resolved Hide resolved
tiledb/common/random/helpers.cc Outdated Show resolved Hide resolved
tiledb/common/random/helpers.h Outdated Show resolved Hide resolved
tiledb/common/random/helpers.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Minor typos

tiledb/common/random/random_label.h Outdated Show resolved Hide resolved
tiledb/common/random/random_label.h Outdated Show resolved Hide resolved
@KiterLuc KiterLuc merged commit 93a464c into dev Dec 21, 2023
60 checks passed
@KiterLuc KiterLuc deleted the rd/random_label branch December 21, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants