Skip to content

Commit

Permalink
Add test
Browse files Browse the repository at this point in the history
  • Loading branch information
kounelisagis committed Dec 30, 2024
1 parent 219262e commit 87c9860
Show file tree
Hide file tree
Showing 2 changed files with 93 additions and 0 deletions.
1 change: 1 addition & 0 deletions test/regression/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ if (TILEDB_CPP_API)
list(APPEND SOURCES targets/sc-53791.cc)
list(APPEND SOURCES targets/sc-53970.cc)
list(APPEND SOURCES targets/sc-54473.cc)
list(APPEND SOURCES targets/sc-60301.cc)
endif()

add_executable(tiledb_regression
Expand Down
92 changes: 92 additions & 0 deletions test/regression/targets/sc-60301.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
/**
* @file sc-60301.cc
*
* @section LICENSE
*
* The MIT License
*
* @copyright Copyright (c) 2024 TileDB, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/

#include <test/support/tdb_catch.h>
#include <tiledb/tiledb>

using namespace tiledb;

static void create_array(Context& ctx, const std::string& array_uri);
static void write_array(Context& ctx, const std::string& array_uri);

TEST_CASE(
"SC-60301: Read data with global cell order returns fill values",
"[dense-reader][bug][global-cell-order][fixed][sc60301]") {
Context ctx;
std::string array_uri = "dense_global_cell_order";

// Test setup
create_array(ctx, array_uri);
write_array(ctx, array_uri);

Array array(ctx, array_uri, TILEDB_READ);
Subarray subarray(ctx, array);
subarray.set_subarray({1, 2, 1, 2});
std::vector<int> a_read;
a_read.resize(4);
Query query(ctx, array);
query.set_subarray(subarray)
.set_layout(TILEDB_GLOBAL_ORDER)
.set_data_buffer("a", a_read);

REQUIRE(query.submit() == Query::Status::COMPLETE);

REQUIRE(a_read[0] == 1);
REQUIRE(a_read[1] == 3);
REQUIRE(a_read[2] == 2);
REQUIRE(a_read[3] == 4);

array.close();
}

void create_array(Context& ctx, const std::string& array_uri) {
auto obj = Object::object(ctx, array_uri);
if (obj.type() != Object::Type::Invalid) {
Object::remove(ctx, array_uri);
}

Domain domain(ctx);
domain.add_dimension(Dimension::create<int>(ctx, "d1", {{1, 2}}, 2))
.add_dimension(Dimension::create<int>(ctx, "d2", {{1, 2}}, 2));

// Create the array schema with col-major cell order and tile order
ArraySchema schema(ctx, TILEDB_DENSE);
schema.set_domain(domain)
.set_order({{TILEDB_COL_MAJOR, TILEDB_COL_MAJOR}})
.add_attribute(Attribute::create<int>(ctx, "a"));
Array::create(ctx, array_uri, schema);
}

void write_array(Context& ctx, const std::string& array_uri) {
std::vector<int> data = {1, 2, 3, 4};
Array array(ctx, array_uri, TILEDB_WRITE);
Query query(ctx, array);
query.set_layout(TILEDB_ROW_MAJOR).set_data_buffer("a", data);
REQUIRE(query.submit() == Query::Status::COMPLETE);
array.close();
}

0 comments on commit 87c9860

Please sign in to comment.