Skip to content

Commit

Permalink
Address final comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bekadavis9 committed Dec 13, 2023
1 parent de88fcf commit 2308151
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/src/unit-capi-vfs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include "test/support/src/vfs_helpers.h"
#include "tiledb/api/c_api/vfs/vfs_api_internal.h"
#include "tiledb/api/c_api_test_support/testsupport_capi_vfs.h"
#include "tiledb/platform/platform.h"
#include "tiledb/sm/c_api/tiledb.h"
#include "tiledb/sm/filesystem/uri.h"
#include "tiledb/sm/misc/utils.h"
Expand Down Expand Up @@ -440,7 +441,7 @@ TEST_CASE("C API: Test virtual filesystem", "[capi][vfs]") {
}

// Check copy (not yet supported for MemFS or HDFS)
if constexpr (!tiledb::sm::filesystem::windows_enabled) {
if constexpr (!tiledb::platform::is_os_windows) {
if (!tiledb::sm::URI::is_memfs(path) && !tiledb::sm::URI::is_hdfs(path)) {
auto dir = path + "dir/";
auto file = dir + "file";
Expand Down
12 changes: 12 additions & 0 deletions test/support/src/vfs_helpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,18 @@ struct vfs_config {
}
}

/** Copy constructor is deleted. */
vfs_config(const vfs_config&) = delete;

/** Move constructor is deleted. */
vfs_config(vfs_config&&) = delete;

/** Copy assignment is deleted. */
vfs_config& operator=(const vfs_config&) = delete;

/** Move assignment is deleted. */
vfs_config& operator=(vfs_config&&) = delete;

/** Destructor. */
~vfs_config() {
tiledb_config_free(&config);
Expand Down

0 comments on commit 2308151

Please sign in to comment.