-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-generate generated API to add new r/w/d organization role. #644
Re-generate generated API to add new r/w/d organization role. #644
Conversation
@NullHypothesis can you re-regenerate and push to see if the conflicts are resolved? |
Thanks for taking a look! I'll pick this back up once the corresponding REST PR is merged. |
adcf1f8
to
246c83b
Compare
This adds the newly-introduced read/write/delete organization role, along with an unrelated change to the spec. I re-generated the API by running: ./update_generated.sh /path/to/TileDB-Cloud-API-Spec
246c83b
to
b35d7b2
Compare
@sgillies This is ready for review but we should hold off on merging until the corresponding REST PR is deployed. I'll un-draft this PR once that's the case. Regarding the code itself: I noticed that re-generating the API on macOS results in a large number of changes while running it on Linux results in exactly what we'd expect. I therefore taught the script to abort if it's run on a non-Linux platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you understand why we see extra changes on macOS even with the same generator version?
This makes it possible to run update_generated.sh on macOS without modifications.
b35d7b2
to
8631bac
Compare
I took another look and realized that this was (mostly) my own fault. I think I didn't properly run the pre-commit hook. That said, one still needs to use GNU sed instead of the default sed on macOS for this to work, which should be fixed in 8631bac. After that, the output is nearly identical to what I'm getting on Linux, except these VERSION changes we don't really matter:
|
@sgillies We should be ready to merge this PR. We deployed the new read/write/delete role in REST earlier today. |
This PR re-generates the generated API to add the new read/write/delete organization role that was introduced in TileDB-Inc/TileDB-Cloud-API-Spec#483. In addition, this PR makes a minor change to make update_generated.sh support macOS.
Note that I re-generated the full API. As far as I can tell, the only change we need is this one.