make exception hashable, an addition to to #184

tests/test_base.py

@@ -13,6 +13,12 @@ def test_obj_equalcheck():
     assert ab.Person(name="hello") == ab2.Person(name="hello")
 
 
+def test_exc_equalcheck():
+    ab = thriftpy.load("addressbook.thrift")
+
+    assert ab.PersonNotExistsError("exc") != ab.PersonNotExistsError("exc")
+
+
 def test_cls_equalcheck():
     ab = thriftpy.load("addressbook.thrift")
     ab2 = thriftpy.load("addressbook.thrift")
@@ -30,9 +36,13 @@ def test_isinstancecheck():
     assert isinstance(ab.PersonNotExistsError(), ab2.PersonNotExistsError)
 
 
-def test_unhashable():
+def test_hashable():
     ab = thriftpy.load("addressbook.thrift")
 
+    # exception is hashable
+    hash(ab.PersonNotExistsError("test error"))
+
+    # container struct is not hashable
     with pytest.raises(TypeError):
         hash(ab.Person(name="Tom"))
 

thriftpy/thrift.py

@@ -250,7 +250,7 @@ def handle_exception(self, e, result):
                 setattr(result, exc_name, e)
                 break
         else:
-            raise
+            raise e
 
     def process(self, iprot, oprot):
         api, seqid, result, call = self.process_in(iprot)
@@ -328,6 +328,12 @@ def get_processor(self):
 class TException(TPayload, Exception):
     """Base class for all thrift exceptions."""
 
+    def __hash__(self):
+        return id(self)
+
+    def __eq__(self, other):
+        return id(self) == id(other)
+
 
 class TDecodeException(TException):
     def __init__(self, name, fid, field, value, ttype, spec=None):