#930 The WebSocket is in an invalid state ('Aborted') for this operation #1030 #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raman-m
added
the
in progress
raman-m
changed the title
raman-m
changed the title
raman-m
requested changes
May 11, 2023
There was a problem hiding this comment.
I do NOT see any fixes!
I see extra code only with extra post-action.
Could you add a couple of unit tests please?
Also, could you write at least one acceptance test please?
Comment on lines
50
to
+54
| await destination.CloseOutputAsync(WebSocketCloseStatus.EndpointUnavailable, null, cancellationToken); | ||
| if (destination.State == WebSocketState.Open || destination.State == WebSocketState.CloseReceived) | ||
| { | ||
| await destination.CloseOutputAsync(WebSocketCloseStatus.EndpointUnavailable, null, cancellationToken); | ||
| } |
There was a problem hiding this comment.
Simple logical challenge:
How many times will the action be applied here?
Once or twice?
The action is CloseOutputAsync.
Comment on lines
61
to
+65
| await destination.CloseOutputAsync(WebSocketCloseStatus.EndpointUnavailable, null, cancellationToken); | ||
| if (destination.State == WebSocketState.Open || destination.State == WebSocketState.CloseReceived) | ||
| { | ||
| await destination.CloseOutputAsync(WebSocketCloseStatus.EndpointUnavailable, null, cancellationToken); | ||
| } |
There was a problem hiding this comment.
Why do you apply the same action twice?
The action is CloseOutputAsync.
|
I'm closing this PR as I can't remember what it was actually about and the original author is actively communicating on #1030 |
raman-m
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened PR: #1030
tdejong-tools4ever commented on Sep 30, 2019