Move compile-mbr.sh script into fail-mbr's automake #255
Conversation
Calling bare tools like "gcc" is not best practise, as this will fail when cross-compiling. We also don't need to rely on tools like rpm when the build already knows which CPU we're building for.
| # compile the file fail-mbr.bin | ||
| #echo -n "Compiling: fail-mbr.S -> fail-mbr.o -> " | ||
| #gcc -Wall -Werror -m32 -nostdlib -static -Wl,--relocatable -o fail-mbr.o fail-mbr.S | ||
|
|
||
| #echo -n "fail-mbr.image -> " | ||
| #gcc -Os -Wall -W -Wshadow -Wpointer-arith -Wmissing-prototypes -Wundef -Wstrict-prototypes -g -falign-jumps=1 -falign-loops=1 -falign-functions=1 -mno-mmx -mno-sse -mno-sse2 -mno-3dnow -fno-dwarf2-cfi-asm -fno-asynchronous-unwind-tables -m32 -fno-stack-protector -mno-stack-arg-probe -Werror -Wno-trampolines -DUSE_ASCII_FAILBACK=1 -DHAVE_UNIFONT_WIDTHSPEC=1 -mrtd -mregparm=3 -fno-builtin -m32 -Wl,--build-id=none -nostdlib -Wl,-N,-S -Wl,-N -Wl,-Ttext,0x7C00 -Wl,--no-dynamic-linker -o fail-mbr.image fail-mbr.o | ||
|
|
||
| #echo "fail-mbr.bin [Done]. " |
There was a problem hiding this comment.
Why did we loose this? These steps are important to know an have, if we are in a similar situation like at #211 again…
There was a problem hiding this comment.
Sorry, it wasn't clear to me why this was commented out. I figured it was just unused. Please could you explain. We could add it back, perhaps as Makefile rules that don't get called automatically.
There was a problem hiding this comment.
I guess it's for targeting 32-bit on 64-bit, but there's only one fail-mbr.bin.orig to compare against?
There was a problem hiding this comment.
Sorry, I'm not an expert at this. I only can tell that the commented steps helped me to track down the difference step by step when using older and newer tools.
Maybe just keep them in a comment for possible future comparison/debugging activities?
There was a problem hiding this comment.
Putting aside the suggestion that this can be dropped, I do find it a little surprising that you can seemingly always get the same result as fail-mbr.bin.orig without all those extra flags. Since that does seem to work, you can just run configure followed by make -C fail-mbr fail-mbr.bin, which will simply build it for you. If you need to tweak the flags, just copy the output and adjust or edit Makefile.am as required.
|
Thank you for your discussions and contributions. This opportunity allowed us to discuss the usage scenarios of the failmbr program, which you can refer to here. |
Calling bare tools like
gccis not best practise, as this will fail when cross-compiling. We also don't need to rely on tools likerpmwhen the build already knows which CPU we're building for.Cross-compiling is still broken for other reasons, but that can be addressed later.