Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mnemonic mapping for pseudoinstructions #45

Draft
wants to merge 12 commits into
base: json
Choose a base branch
from
Draft

Add mnemonic mapping for pseudoinstructions #45

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b5c738a
Parse pseudoinstructions from AST and add to Hashtbl
Linda-Njau Oct 30, 2024
783185a
Add function to process base instructions
Linda-Njau Nov 5, 2024
9c62811
Add function for mnemonic retrieval
Linda-Njau Nov 6, 2024
dd68065
Add function to return matched argument
Linda-Njau Nov 11, 2024
a81da7f
Add function to return index of an element in a list
Linda-Njau Nov 11, 2024
49dd15f
Add function to retrieve mnemonic for a given argument
Linda-Njau Nov 12, 2024
20cd11c
Fix misplaced line and adjust list iteration function
Linda-Njau Nov 20, 2024
eb4611c
Add variable for regex pattern matching the string in parentheses
Linda-Njau Nov 20, 2024
35af3fd
Refactor match expressions to use a catch-all case
Linda-Njau Nov 20, 2024
b95e0f2
Refactor index search function
Linda-Njau Nov 21, 2024
67fa077
Refactor `map_arg_to_mnemonic` to use direct iteration
Linda-Njau Nov 21, 2024
e2799d9
Remove pkg-config from macOS dependencies
Linda-Njau Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/sail_json_backend/json.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,16 @@ let parse_funcl fcl =
end
| _ -> debug_print "FCL_funcl other"

let map_arg_to_mnemonic arg id = None
let map_arg_to_mnemonic arg id =
List.find_map
(fun (enum, mnemonic) ->
if List.hd enum = arg then (
debug_print ("Matched " ^ List.hd enum ^ " with mnemonic: " ^ List.hd mnemonic);
Some (List.hd mnemonic)
)
else None
)
(Hashtbl.find_all mappings (String.lowercase_ascii (id ^ "_mnemonic")))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is relying on a convention used to identify mappings for mnemonics in the Sail code. Since this is not guaranteed, please add a comment indicating assumptions you are making here.

Also, I see similar conventions which likely violate the assumptions, like:

mapping f_madd_type_mnemonic_D : f_madd_op_D <-> string = {
    FMADD_D  <-> "fmadd.d",
    FMSUB_D  <-> "fmsub.d",
    FNMSUB_D <-> "fnmsub.d",
    FNMADD_D <-> "fnmadd.d"
}

Would it work to use all entries in the "mappings" table?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to go the all entries route for this


let get_index elem lst =
List.find_map (fun (i, x) -> if x = elem then Some i else None) (List.mapi (fun i x -> (i, x)) lst)
Expand Down
Loading