Fix name and description extraction #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add the text you have in the PR description into the commit message, please? |
Linda-Njau
force-pushed
the
json
branch
2 times, most recently
from
51c6e53 to
3b9d66e
Compare
|
Done : )
|
Linda-Njau
force-pushed
the
json
branch
2 times, most recently
from
32bbb4c to
606d8f9
Compare
Instructions with fewer than two inputs were missing their names and descriptions in the JSON output. ``` union clause ast = C_J : (bits(11)) ``` ``` union clause ast = EBREAK : unit ``` By moving the code blocks responsible for parsing and extracting names and descriptions from the tuple match block, all instructions now have their names and descriptions correctly extracted.
ThinkOpenly
reviewed
Aug 16, 2024
ThinkOpenly
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions with fewer than two inputs were missing their names and descriptions in the JSON output.
union clause ast = C_J : (bits(11))union clause ast = EBREAK : unitBy moving the code blocks responsible for parsing and extracting names and descriptions from the tuple match block, all instructions now have their names and descriptions correctly extracted.