fix workflow

.github/workflows/build.yml

@@ -9,7 +9,7 @@ jobs:
   build:
     strategy:
       matrix:
-        version: [4.08.1, 5.0.0]
+        version: [4.14.0, 5.0.0]
         os: [ubuntu-latest, macOS-latest]
 
     runs-on: ${{ matrix.os }}

0001-fix-build-failure-in-github-workflow.patch

@@ -0,0 +1,144 @@
+From ccf322215f801dbb278cc63a38ec9d4f314962c8 Mon Sep 17 00:00:00 2001
+From: Nitish <[email protected]>
+Date: Sat, 1 Jun 2024 12:03:41 +0530
+Subject: [PATCH] fix build failure in github workflow
+
+---
+ sail_json_backend.opam        | 43 +++++++++++++++++++++++++++++++++++
+ src/sail_json_backend/json.ml | 32 +++++++++++++++++++-------
+ 2 files changed, 67 insertions(+), 8 deletions(-)
+ create mode 100644 sail_json_backend.opam
+
+diff --git a/sail_json_backend.opam b/sail_json_backend.opam
+new file mode 100644
+index 00000000..b4f01652
+--- /dev/null
++++ b/sail_json_backend.opam
+@@ -0,0 +1,43 @@
++# This file is generated by dune, edit dune-project instead
++opam-version: "2.0"
++version: "0.17"
++synopsis: "Sail to JSON formatting"
++maintainer: ["Sail Devs <[email protected]>"]
++authors: [
++  "Alasdair Armstrong"
++  "Thomas Bauereiss"
++  "Brian Campbell"
++  "Shaked Flur"
++  "Jonathan French"
++  "Kathy Gray"
++  "Robert Norton"
++  "Christopher Pulte"
++  "Peter Sewell"
++  "Mark Wassell"
++]
++license: "BSD-2-Clause"
++homepage: "https://github.com/rems-project/sail"
++bug-reports: "https://github.com/rems-project/sail/issues"
++depends: [
++  "dune" {>= "3.0"}
++  "libsail" {= version}
++  "omd" {>= "1.3.1" & < "1.4.0"}
++  "odoc" {with-doc}
++]
++build: [
++  ["dune" "subst"] {dev}
++  [
++    "dune"
++    "build"
++    "-p"
++    name
++    "-j"
++    jobs
++    "--promote-install-files=false"
++    "@install"
++    "@runtest" {with-test}
++    "@doc" {with-doc}
++  ]
++  ["dune" "install" "-p" name "--create-install-files" name]
++]
++dev-repo: "git+https://github.com/rems-project/sail.git"
+diff --git a/src/sail_json_backend/json.ml b/src/sail_json_backend/json.ml
+index 83ae0fd3..60b31638 100644
+--- a/src/sail_json_backend/json.ml
++++ b/src/sail_json_backend/json.ml
+@@ -71,6 +71,9 @@ open Ast
+ open Ast_defs
+ open Ast_util
+
++external length : string -> int = "%string_length"
++external unsafe_get : string -> int -> char = "%string_unsafe_get"
++
+ let debug_enabled =
+   match Sys.getenv_opt "SAIL_DEBUG" with Some value -> value = "1" || int_of_string_opt value = Some 1 | None -> false
+
+@@ -91,9 +94,23 @@ let mappings = Hashtbl.create 997
+
+ let debug_print ?(printer = prerr_endline) message = if debug_enabled then printer message else ()
+
++(* excerpt taken from ocaml/stdlib/string.ml *)
++let starts_with ~prefix s =
++  let len_s = length s and len_pre = length prefix in
++  let rec aux i = if i = len_pre then true else if unsafe_get s i <> unsafe_get prefix i then false else aux (i + 1) in
++  len_s >= len_pre && aux 0
++
++(* excerpt taken from ocaml/stdlib/string.ml *)
++let ends_with ~suffix s =
++  let len_s = length s and len_suf = length suffix in
++  let diff = len_s - len_suf in
++  let rec aux i =
++    if i = len_suf then true else if unsafe_get s (diff + i) <> unsafe_get suffix i then false else aux (i + 1)
++  in
++  diff >= 0 && aux 0
++
+ let dequote qs =
+-  if String.starts_with ~prefix:"\"" qs && String.ends_with ~suffix:"\"" qs then
+-    List.hd (List.tl (String.split_on_char '"' qs))
++  if starts_with ~prefix:"\"" qs && ends_with ~suffix:"\"" qs then List.hd (List.tl (String.split_on_char '"' qs))
+   else qs
+
+ let string_of_arg = function E_aux (E_id id, _) -> "\"" ^ string_of_id id ^ "\"" | exp -> "exp " ^ string_of_exp exp
+@@ -394,8 +411,7 @@ let identity_funcs =
+   ]
+
+ let defunction f n =
+-  if String.starts_with ~prefix:(n ^ "(") f then
+-    String.sub f (String.length n + 1) (String.length f - String.length n - 2)
++  if starts_with ~prefix:(n ^ "(") f then String.sub f (String.length n + 1) (String.length f - String.length n - 2)
+   else f
+
+ let remove_identity_funcs op =
+@@ -529,10 +545,10 @@ let extract_func_arg s = List.hd (String.split_on_char ')' (List.hd (List.tl (St
+ let rec string_of_sizeof_field k f =
+   debug_print ("string_of_sizeof_field " ^ k ^ ":" ^ f);
+
+-  if String.starts_with ~prefix:"0b" f then (* binary literal "0b..." *)
++  if starts_with ~prefix:"0b" f then (* binary literal "0b..." *)
+     string_of_int (String.length f - 2)
+   else if String.contains f '(' then
+-    if String.starts_with ~prefix:"bits(" f then (* bits(n) *)
++    if starts_with ~prefix:"bits(" f then (* bits(n) *)
+       extract_func_arg f
+     else (
+       let op_func = List.hd (String.split_on_char '(' f) in
+@@ -549,7 +565,7 @@ let rec string_of_sizeof_field k f =
+           (* try to drill down to a base type *)
+           let bt = basetype t in
+           if bt = "bool" then "1"
+-          else if String.starts_with ~prefix:"bits(" bt then extract_func_arg bt
++          else if starts_with ~prefix:"bits(" bt then extract_func_arg bt
+           else begin
+             debug_print ("unfamiliar base type " ^ bt);
+             "72" (* TODO: needs work *)
+@@ -649,7 +665,7 @@ let rec explode_mnemonics asm =
+   else if String.equal (List.hd asm) "spc" then ["" :: List.tl asm]
+   else (
+     let tails = explode_mnemonics (List.tl asm) in
+-    if String.ends_with ~suffix:")" (List.hd asm) then begin
++    if ends_with ~suffix:")" (List.hd asm) then begin
+       debug_print (extract_func_arg (List.hd asm));
+       let heads = Hashtbl.find_all mappings (List.hd (String.split_on_char '(' (List.hd asm))) in
+       let found =
+-- 
+2.45.1
+