Skip to content

Commit

Permalink
Remove macos12 4.08.1 build (#37)
Browse files Browse the repository at this point in the history
GitHub CI "build" Action often fails on target "macos-12" with errors like:
```
=== ERROR while compiling sail_json_backend.0.17 =============================
     File "src/sail_json_backend/json.ml", line 97, characters 5-23:
     97 |   if String.starts_with ~prefix:"\"" qs && String.ends_with ~suffix:"\"" qs then
               ^^^^^^^^^^^^^^^^^^
     Error: Unbound value String.starts_with
```

  - This error message is indicative of an outdated version of OCaml.
  - Support in OCaml for `String.starts_with` arrived in OCaml 4.13, which
    was released almost 2 years ago (2021-09-24).
  - This issue occurs on the "macos-12" target exclusively.
  - Since the work being done here is not platform-specific and is at the
    level of "proof-of-concept", we can disable the "macos-12" platform
    and move on.
  • Loading branch information
joydeep049 authored Aug 15, 2024
1 parent 454f4c8 commit 9361db7
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ jobs:
matrix:
version: [5.0.0]
os: [ubuntu-latest, macOS-latest]
include:
- os: macos-12
version: 4.08.1
exclude:
- os: macos-latest
version: 4.08.1
Expand Down

0 comments on commit 9361db7

Please sign in to comment.