Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested oneof fields code generation #31

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Fix nested oneof fields code generation #31

merged 2 commits into from
Sep 23, 2019

Conversation

adriansmares
Copy link
Contributor

Summary

Closes #30.

Changes

Notes for Reviewers

None.

@adriansmares adriansmares added this to the September 2019 milestone Sep 23, 2019
@adriansmares adriansmares self-assigned this Sep 23, 2019
@adriansmares adriansmares changed the title Fix/oneof setfields Fix nested oneof fields code generation Sep 23, 2019
@rvolosatovs
Copy link
Contributor

rvolosatovs commented Sep 23, 2019 •
edited
Loading

Another reason to do #23 - it's way too easy to make mistakes with current implementation

@rvolosatovs rvolosatovs merged commit dcc6c3c into master Sep 23, 2019
@rvolosatovs rvolosatovs deleted the fix/oneof-setfields branch September 23, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

Assignees

@rvolosatovs rvolosatovs

Labels
prio/high
Projects
None yet
Milestone
September 2019
Development

Successfully merging this pull request may close these issues.

Wrong oneof sub-fields
2 participants
@adriansmares @rvolosatovs