[unreal]处理内存重用导致的Check failed: Handle not reset in first callback. Se…

…e comments on |v8::WeakCallbackInfo| fix #1930
Tencent · Dec 3, 2024 · 88c3ab3 · 88c3ab3
1 parent 8815721
commit 88c3ab3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/unreal/Puerts/Source/JsEnv/Private/CppObjectMapper.cpp b/unreal/Puerts/Source/JsEnv/Private/CppObjectMapper.cpp
@@ -304,7 +304,7 @@ void FCppObjectMapper::BindCppObject(
     FObjectCacheNode* CacheNodePtr;
     if (Iter != CDataCache.end())
     {
-        CacheNodePtr = Iter->second.Add(ClassDefinition->TypeId);
+        CacheNodePtr = &Iter->second;
     }
     else
     {

diff --git a/unreal/Puerts/Source/JsEnv/Private/JsEnvImpl.cpp b/unreal/Puerts/Source/JsEnv/Private/JsEnvImpl.cpp
@@ -2913,11 +2913,7 @@ void FJsEnvImpl::BindStruct(
         }
 #endif
         auto CacheNodePtr = StructCache.Find(Ptr);
-        if (CacheNodePtr)
-        {
-            CacheNodePtr = CacheNodePtr->Add(ScriptStructWrapper->Struct.Get());
-        }
-        else
+        if (!CacheNodePtr)
         {
             CacheNodePtr = &StructCache.Emplace(Ptr, FObjectCacheNode(ScriptStructWrapper->Struct.Get()));
         }