Consider when the file is used with pnpm isolated mode. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows to keep the same logic when we override the package name. Also, using path for safer and cleaner path resolution.
…llback to 0.3.2 behavior.
-> double quote, semicolon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under pnpm isolated mode, the variable
__dirnamereturn./node_modules/.pnpm/@[email protected]/node_modules/@mdi/util.Due to the isolated mode of pnpm (default mode), the module
@mdi/svgis not found at${__dirname}/../.This changes will detect if we have a
node_modulesunder theprocess.cwd(). If so, it will use this folder to find@mdi/svg.Note, I am not using yarn, so maybe this one is not working either, but in any case, it should fallback to the previous 0.3.2 behavior if
@mdi/svgis not found innode_modules.