HDDS-12159. Remove redundant seek for rocksDBs

Tejaskriya · Feb 3, 2025 · f4bbd9d · f4bbd9d
1 parent fc89ba6
commit f4bbd9d
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 15 deletions.
diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
@@ -2130,9 +2130,7 @@ public List<OmKeyInfo> getPendingDeletionSubFiles(long volumeId,
 
     Table fileTable = metadataManager.getFileTable();
     try (TableIterator<String, ? extends Table.KeyValue<String, OmKeyInfo>>
-        iterator = fileTable.iterator()) {
-
-      iterator.seek(seekFileInDB);
+        iterator = fileTable.iterator(seekFileInDB)) {
 
       while (iterator.hasNext() && numEntries - countEntries > 0) {
         Table.KeyValue<String, OmKeyInfo> entry = iterator.next();

diff --git a/...p-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java b/...p-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
@@ -1956,8 +1956,7 @@ public Set<String> getMultipartUploadKeys(
     }
 
     try (TableIterator<String, ? extends KeyValue<String, OmMultipartKeyInfo>>
-        iterator = getMultipartInfoTable().iterator()) {
-      iterator.seek(prefixKey);
+        iterator = getMultipartInfoTable().iterator(prefixKey)) {
 
       while (iterator.hasNext()) {
         KeyValue<String, OmMultipartKeyInfo> entry = iterator.next();

diff --git a/.../ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequestUtils.java b/.../ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequestUtils.java
@@ -75,8 +75,7 @@ public static boolean isSnapshotBucket(OMMetadataManager omMetadataManager,
   private static boolean checkInSnapshotDB(OMMetadataManager omMetadataManager,
       String dbSnapshotBucketKey) throws IOException {
     try (TableIterator<String, ? extends Table.KeyValue<String, SnapshotInfo>>
-        iterator = omMetadataManager.getSnapshotInfoTable().iterator()) {
-      iterator.seek(dbSnapshotBucketKey);
+        iterator = omMetadataManager.getSnapshotInfoTable().iterator(dbSnapshotBucketKey)) {
       return iterator.hasNext() && iterator.next().getKey()
           .startsWith(dbSnapshotBucketKey);
     }

diff --git a/...anager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketDeleteRequest.java b/...anager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketDeleteRequest.java
@@ -242,8 +242,7 @@ private boolean bucketContainsSnapshotInTable(
     try (
         TableIterator<String, ? extends Table.KeyValue<String, SnapshotInfo>>
             snapshotIterator = omMetadataManager
-            .getSnapshotInfoTable().iterator()) {
-      snapshotIterator.seek(snapshotBucketKey);
+            .getSnapshotInfoTable().iterator(snapshotBucketKey)) {
       if (snapshotIterator.hasNext()) {
         return snapshotIterator.next().getKey().startsWith(snapshotBucketKey);
       }

diff --git a/...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java b/...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
@@ -906,9 +906,7 @@ private static boolean checkSubDirectoryExists(OmKeyInfo omKeyInfo,
             omKeyInfo.getObjectID(), "");
     try (TableIterator<String, ? extends
         Table.KeyValue<String, OmDirectoryInfo>>
-            iterator = dirTable.iterator()) {
-
-      iterator.seek(seekDirInDB);
+            iterator = dirTable.iterator(seekDirInDB)) {
 
       if (iterator.hasNext()) {
         Table.KeyValue<String, OmDirectoryInfo> entry = iterator.next();
@@ -952,9 +950,7 @@ private static boolean checkSubFileExists(OmKeyInfo omKeyInfo,
     String seekFileInDB = metaMgr.getOzonePathKey(volumeId, bucketId,
             omKeyInfo.getObjectID(), "");
     try (TableIterator<String, ? extends Table.KeyValue<String, OmKeyInfo>>
-            iterator = fileTable.iterator()) {
-
-      iterator.seek(seekFileInDB);
+            iterator = fileTable.iterator(seekFileInDB)) {
 
       if (iterator.hasNext()) {
         Table.KeyValue<String, OmKeyInfo> entry = iterator.next();