Add link to donation page on app drawer #11870
Merged
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
previously requested changes
Jan 2, 2025
AudricV
changed the title
AudricV
added
the
template missing
Profpatsch
force-pushed
the
sidebar_donations
branch
from
7e10f6f to
e00f843
Compare
|
I switched over to the
|
|
Shouldn't you do "openInBrowser" instead of "openInApp"? |
Profpatsch
force-pushed
the
sidebar_donations
branch
from
e00f843 to
6a89d78
Compare
|
Done |
Stypox
previously requested changes
Jan 25, 2025
Profpatsch
force-pushed
the
sidebar_donations
branch
from
6a89d78 to
311076a
Compare
|
I removed the toast because people thought it is confusing. I do think something like the toast could be more encouraging :) |
This creates a donation link that leads to our donation page on the NewPipe website.
Profpatsch
force-pushed
the
sidebar_donations
branch
from
311076a to
33ecfb7
Compare
|
Okay, so now sonar is broken and that blocks the PR |
|
Ah no, apparently somebody has to review again |
Profpatsch
approved these changes
Jan 27, 2025
|
As a user I would like to have the option to turn this off completely. Maybe some users donate already and do not want to see the button every time they open the app. |
|
The button is at the bottom of the drawer, it's not in the way. Why would you want to disable it? @robcle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At 38c3 we discussed how we could make the request for donations more visible. We discussed multiple models. Ultimately we could not agree on a good solution to actually ask the user for donations.
However, we all agreed that donations should be more visible than just show up in the about screen.
This will add the link for donations to the app drawer. When clicking it will open the donation page of the NewPipe website.
