Skip to content

Commit

Permalink
♻️: refactor Every to All로 네이밍 변경 #38
Browse files Browse the repository at this point in the history
  • Loading branch information
sookyungg committed Apr 6, 2024
1 parent e0e9e59 commit 08f9025
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import com.th.plu.api.controller.answer.dto.response.AnswerInfoResponse
import com.th.plu.api.controller.answer.dto.response.EveryAnswerInfoResponse
import com.th.plu.api.controller.answer.dto.toAnswerWriting
import com.th.plu.api.controller.answer.dto.toWritingAnswerResponse
import com.th.plu.common.dto.response.ApiResponse
import com.th.plu.api.service.answer.AnswerService
import com.th.plu.common.dto.response.ApiResponse
import com.th.plu.domain.domain.answer.dto.EveryAnswerRetrieveResponses
import io.swagger.v3.oas.annotations.Operation
import io.swagger.v3.oas.annotations.tags.Tag
Expand Down Expand Up @@ -62,7 +62,7 @@ class AnswerController(
@GetMapping("/v1/answers/info")
fun findEveryAnswerInfo(
): ApiResponse<EveryAnswerInfoResponse> {
return ApiResponse.success(answerService.findEveryAnswerInfo())
return ApiResponse.success(answerService.findAllAnswerInfo())
}

@Auth
Expand All @@ -72,7 +72,7 @@ class AnswerController(
@RequestParam(defaultValue = Long.MAX_VALUE.toString()) lastAnswerId: Long,
@RequestParam(defaultValue = "10") pageSize: Long,
): ApiResponse<EveryAnswerRetrieveResponses> {
return ApiResponse.success(answerService.findEveryAnswersWithCursor(lastAnswerId, pageSize))
return ApiResponse.success(answerService.findAllAnswersWithCursor(lastAnswerId, pageSize))
}

@Auth
Expand All @@ -81,6 +81,6 @@ class AnswerController(
fun getAnswersAboutLikeTopN(
@RequestParam(defaultValue = "10") getCount: Long,
): ApiResponse<EveryAnswerRetrieveResponses> {
return ApiResponse.success(answerService.findEveryAnswersLikeTopN(getCount))
return ApiResponse.success(answerService.findAllAnswersLikeTopN(getCount))
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,21 @@ class AnswerService(
}

@Transactional(readOnly = true)
fun findEveryAnswersWithCursor(lastAnswerId: Long, pageSize: Long): EveryAnswerRetrieveResponses {
fun findAllAnswersWithCursor(lastAnswerId: Long, pageSize: Long): EveryAnswerRetrieveResponses {
val todayQuestionId = questionExplorer.findTodayQuestion().id
val answers = answerRepository.findEveryAnswersWithCursorAndPageSize(todayQuestionId, lastAnswerId, pageSize)
return EveryAnswerRetrieveResponses(answers)
}

@Transactional(readOnly = true)
fun findEveryAnswerInfo(): EveryAnswerInfoResponse {
fun findAllAnswerInfo(): EveryAnswerInfoResponse {
val todayQuestion = questionExplorer.findTodayQuestion()
val answerCount = answerRepository.findPublicAnswersCountByQuestionId(todayQuestion.id)

return EveryAnswerInfoResponse.of(todayQuestion, answerCount)
}

fun findEveryAnswersLikeTopN(getCount: Long): EveryAnswerRetrieveResponses {
fun findAllAnswersLikeTopN(getCount: Long): EveryAnswerRetrieveResponses {
val todayQuestion = questionExplorer.findTodayQuestion()
val answers = answerRepository.findPublicAnswersLikeTopN(todayQuestion.id, getCount)

Expand Down

0 comments on commit 08f9025

Please sign in to comment.