[FIX/#255] Todo / QA 이슈사항 대응 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crownjoe
approved these changes
Mar 14, 2024
| style="@style/TextAppearance.Doorip.Head1" | ||
| style="@style/TextAppearance.Doorip.Head2" |
leeeyubin
approved these changes
Mar 14, 2024
Comment on lines
+60
to
+61
| android:textColor="@{vm.isFinishAvailable() == true ? @color/red_500 : @color/gray_200}" | ||
| app:layout_constraintBottom_toBottomOf="@id/tv_todo_create_title" |
chattymin
approved these changes
Mar 14, 2024
Comment on lines
+95
to
+96
| etEmojiCounterEtContent.maxLines = | ||
| typedArray.getInt(R.styleable.EmojiCounterEditText_minLines, 2) |
There was a problem hiding this comment.
대부분은 minLine을 설정 안하니까 default인 1이 maxLine이 되고, minLine을 설정한 친구(메모)같은 애들은 minLine만큼 맥스라인이 되는걸까요?
| @@ -91,6 +92,9 @@ class EmojiCounterEditText(context: Context, attrs: AttributeSet) : | |||
| typedArray.getString(R.styleable.EmojiCounterEditText_hint) | |||
| etEmojiCounterEtContent.minLines = | |||
| typedArray.getInt(R.styleable.EmojiCounterEditText_minLines, 1) | |||
| etEmojiCounterEtContent.maxLines = | |||
| typedArray.getInt(R.styleable.EmojiCounterEditText_minLines, 2) | |||
| etEmojiCounterEtContent.movementMethod = ScrollingMovementMethod() | |||
There was a problem hiding this comment.
이걸 커스텀뷰에 넣어버리면 모든 애들이 다 스크롤이될텐데 괜찮나???
There was a problem hiding this comment.
현재 기본 커스텀뷰 설정은 기본 1줄, 길어지면 2줄 (근데 대부분 최대 15자 제한 있음), 3줄보다 길어지면 작성이 안되는게 아니라 높이는 2줄짜리에서 스크롤 될 수 있도록 설정했음 ! (메모의 경우 따로 둘다 6줄로 설정)
지금은 기본 maxLine 설정이 없었어서, 투두제목에서 한글자하고 띄우고 해서 15줄짜리 제목도 만들 수 있길래, UI적으로 이게 더 나을 것 같아서 !
…into fix/#255-todo-2nd-qa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description